-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression when parent list of a Content field had a where
clau…
#1673
Conversation
…se as its access control.
🦋 Changeset is good to goLatest commit: 5275bff We got this. Not sure what this means? Click here to learn what changesets are. |
@@ -51,7 +51,16 @@ export class OEmbedBlock extends Block { | |||
'A reference back to the Slate.js Serialised Document this embed is contained within', | |||
}, | |||
}, | |||
access: listConfig.listAccess, | |||
access: Object.entries(listConfig.listAccess).reduce( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Util function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now used 3 times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 times!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe, but also I don't have time right now :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The real refactor should come one level higher with the way we create these Aux lists for blocks, but that's future Tim's problem.
…se as its access control.